Fix specs according to review

ManageIQ · Apr 6, 2018 · 55ed535 · 55ed535
1 parent aa80005
commit 55ed535
Showing 1 changed file with 11 additions and 16 deletions.
diff --git a/spec/migrations/20180405145642_remove_provider_region_for_google_provider_spec.rb b/spec/migrations/20180405145642_remove_provider_region_for_google_provider_spec.rb
@@ -4,26 +4,21 @@
   let(:ems_stub) { migration_stub :ExtManagementSystem }
 
   migration_context :up do
-    before do
-      ems_stub.create!(:type            => 'ManageIQ::Providers::Google::CloudManager',
-                       :provider_region => 42)
-      ems_stub.create!(:type            => 'ManageIQ::Providers::Amazon::CloudManager',
-                       :provider_region => 42)
-      ems_stub.create!(:type            => 'ManageIQ::Providers::Azure::CloudManager',
-                       :provider_region => 42)
-      ems_stub.create!(:type            => 'ManageIQ::Providers::Openstack::CloudManager',
-                       :provider_region => 42)
-      ems_stub.create!(:type            => 'ManageIQ::Providers::Vmware::CloudManager',
-                       :provider_region => 42)
+    ems_stub.create!(:type            => 'ManageIQ::Providers::Google::CloudManager',
+                     :provider_region => 42)
+    ems_stub.create!(:type            => 'ManageIQ::Providers::Amazon::CloudManager',
+                     :provider_region => 42)
+    ems_stub.create!(:type            => 'ManageIQ::Providers::Azure::CloudManager',
+                     :provider_region => 42)
+    ems_stub.create!(:type            => 'ManageIQ::Providers::Openstack::CloudManager',
+                     :provider_region => 42)
+    ems_stub.create!(:type            => 'ManageIQ::Providers::Vmware::CloudManager',
+                     :provider_region => 42)
 
+    it 'does sets provider_region to nil only to Google provider' do
       migrate
-    end
 
-    it 'sets provider_region to nil for ManageIQ::Providers::Google::CloudManager' do
       expect(ems_stub.where(:provider_region => nil).count).to eq 1
-    end
-
-    it 'does not set provider_region to nil for other providers' do
       expect(ems_stub.where(:provider_region => 42).count).to eq 4
     end
   end