Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to support ppc64le #76

Merged
merged 7 commits into from
Jul 20, 2020
Merged

Changes to support ppc64le #76

merged 7 commits into from
Jul 20, 2020

Conversation

seth-priya
Copy link
Contributor

Fixes for ppc64le, reference issue #43

@simaishi simaishi mentioned this pull request Jul 16, 2020
Closed
5 tasks
@gtanzillo gtanzillo added the enhancement New feature or request label Jul 16, 2020
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2020

Checked commits seth-priya/manageiq-rpm_build@4500fe0~...f51bdb9 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@seth-priya
Copy link
Contributor Author

seth-priya commented Jul 17, 2020 •
edited
Loading

@simaishi implemented review comments ..

Fryguy
Fryguy approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... @simaishi ?

@simaishi
Copy link
Contributor

Looks good!

@simaishi simaishi merged commit f70f75f into ManageIQ:master Jul 20, 2020
@sethpeterson
Copy link

@miq-bot add-label jansa/yes?

simaishi added a commit that referenced this pull request Jul 21, 2020
@simaishi
Merge pull request #76 from seth-priya/master
d443e49 
Changes to support ppc64le

(cherry picked from commit f70f75f)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit d443e49cbbcf502134e670bd3622275525babe6e
Author: Satoe Imaishi <[email protected]>
Date:   Mon Jul 20 14:02:48 2020 -0400

    Merge pull request #76 from seth-priya/master

    Changes to support ppc64le

    (cherry picked from commit f70f75face2c76e25f5ab177597862d9087bc616)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simaishi simaishi simaishi left review comments

@Fryguy Fryguy Fryguy approved these changes

Assignees

@simaishi simaishi

Labels
enhancement New feature or request jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seth-priya @miq-bot @simaishi @sethpeterson @Fryguy @gtanzillo