Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repmgr build in mock #341

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix repmgr build in mock #341

merged 1 commit into from
Nov 22, 2022

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Nov 22, 2022

  • Ensure postgres is v13
  • Ensure the postgres 13 module is enabled for build

@bdunne
Fix repmgr build in mock
d7b2be2 
- Ensure postgres is v13
- Ensure the postgres 13 module is enabled for build
@bdunne bdunne added the bug Something isn't working label Nov 22, 2022
@bdunne bdunne requested a review from jrafanie November 22, 2022 22:29
@Fryguy Fryguy mentioned this pull request Nov 22, 2022
Merged
jrafanie
jrafanie reviewed Nov 22, 2022
View reviewed changes
packages/repmgr13/README
@@ -3,5 +3,5 @@ Build with:
Fetch source files from https://rpm-manageiq-org.nyc3.digitaloceanspaces.com/index.html?prefix=sources_cache/repmgr13/ if needed.

```bash
mock --spec=./repmgr.spec -r centos-stream+epel-8-x86_64 --sources=./
mock --spec=./repmgr.spec -r centos-stream+epel-8-x86_64 --config-opts=module_setup_commands.module_install=postgresql:13 --sources=./
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. :neckbeard:

jrafanie
jrafanie reviewed Nov 22, 2022
View reviewed changes
packages/repmgr13/repmgr.spec
@@ -46,7 +46,7 @@ Requires(postun): initscripts
Group: Applications/Databases
BuildRoot: %{_tmppath}/%{name}-%{version}%{extra_version}-%{release}-root-%(%{__id_u} -n)
%endif
BuildRequires: postgresql, postgresql-devel, postgresql-static
BuildRequires: postgresql >= 13, postgresql < 14, postgresql-devel, postgresql-static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jrafanie
jrafanie approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jrafanie jrafanie merged commit f51e0d8 into ManageIQ:master Nov 22, 2022
@bdunne bdunne mentioned this pull request Nov 22, 2022
Merged
bdunne added a commit to bdunne/manageiq-rpm_build that referenced this pull request Nov 23, 2022
@bdunne
Ensure repmgr13 is build against postgres 13
1128a96 
Based on: ManageIQ#341
@bdunne bdunne mentioned this pull request Nov 23, 2022
Closed
@Fryguy
Copy link
Member

Fryguy commented Dec 2, 2022

@bdunne A conflict occurred during the backport of this pull request to oparin.

If this pull request is based on another pull request that has not been marked for backport, add the appropriate labels to the other pull request. Otherwise, please create a new pull request direct to the oparin branch in order to resolve this.

Conflict details:

* Unmerged path packages/repmgr13/README

@Fryguy
Copy link
Member

Fryguy commented Dec 2, 2022

Backported to oparin in commit b7d1219.

commit b7d121980c69e856d63f1fad597f249fe4879fec
Author: Joe Rafaniello <[email protected]>
Date:   Tue Nov 22 17:34:28 2022 -0500

    Merge pull request #341 from bdunne/repmrg_postgres_version
    
    (cherry picked from commit f51e0d88f3243165a46deaf8aec948f3756c5bd4)

Fryguy pushed a commit that referenced this pull request Dec 2, 2022
@jrafanie @Fryguy
Merge pull request #341 from bdunne/repmrg_postgres_version
b7d1219 
(cherry picked from commit f51e0d8)
@jrafanie jrafanie mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

@Fryguy Fryguy Fryguy approved these changes

Assignees

@jrafanie jrafanie

Labels
bug Something isn't working dependencies oparin/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdunne @Fryguy @jrafanie