Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Generator Updates #628

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Plugin Generator Updates #628

merged 1 commit into from
Sep 18, 2020

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Sep 17, 2020

Plugin Generator Updates

@Fryguy Fryguy requested a review from agrare as a code owner September 17, 2020 21:11
@Fryguy Fryguy force-pushed the plugin_generator_changes branch from af81860 to c4a9b06 Compare September 18, 2020 15:52
@Fryguy
Copy link
Member Author

Fryguy commented Sep 18, 2020

@agrare Updated.

@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2020

Checked commit Fryguy@c4a9b06 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
6 files checked, 2 offenses detected

lib/manageiq-providers-vmware.rb

  • ❗ - Line 1, Col 1 - Naming/FileName - The name of this source file (manageiq-providers-vmware.rb) should use snake_case.

spec/spec_helper.rb

@agrare agrare self-assigned this Sep 18, 2020
@agrare agrare merged commit d324862 into ManageIQ:master Sep 18, 2020
@Fryguy Fryguy deleted the plugin_generator_changes branch November 30, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fryguy @miq-bot @agrare