Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provision: use the proper term for preloads #567

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 1, 2020

Lan has one switch, not many.

This changes the preloaded to have the correct term

This was causing a problem in rails 5.2

Failure/Error: MiqPreloader.preload(all_hosts, :lans => :switches)
     
ActiveRecord::AssociationNotFoundError:
Association named 'switches' was not found on Lan; perhaps you misspelled it?

Lan has one switch, not many.

This changes the preloaded to have the correct term

Failure/Error: MiqPreloader.preload(all_hosts, :lans => :switches)
     
ActiveRecord::AssociationNotFoundError:
Association named 'switches' was not found on Lan; perhaps you misspelled it?
@kbrock kbrock requested review from agrare and Fryguy as code owners April 1, 2020 22:07
@miq-bot
Copy link
Member

miq-bot commented Apr 1, 2020

Checked commit kbrock@ee86b14 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare agrare merged commit fff6c5b into ManageIQ:master Apr 1, 2020
@agrare agrare self-assigned this Apr 1, 2020
@kbrock kbrock deleted the provision_workflow branch April 2, 2020 06:45
@jrafanie
Copy link
Member

jrafanie commented Apr 2, 2020

@miq-bot add_label jansa/yes?

@chessbyte chessbyte mentioned this pull request Apr 2, 2020
38 tasks
simaishi pushed a commit that referenced this pull request Apr 3, 2020
provision: use the proper term for preloads
(cherry picked from commit fff6c5b)
@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2020

Jansa backport details:

$ git log -1
commit 35a2785c895a34461766ec0aa90998da9b232cdb
Author: Adam Grare <[email protected]>
Date:   Wed Apr 1 18:41:57 2020 -0400

    Merge pull request #567 from kbrock/provision_workflow

    provision: use the proper term for preloads
    (cherry picked from commit fff6c5b050791ab28e78ae161d94413fcd580175)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants