-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completely remove the VimBrokerWorker #506
Completely remove the VimBrokerWorker #506
Conversation
@agrare Can you rebase now that other PRs are merged? |
5de716a
to
8b44a71
Compare
9d76977
to
ae7a9a9
Compare
f8d123d
to
afa3507
Compare
app/models/manageiq/providers/vmware/infra_manager/provision/state_machine.rb
Show resolved
Hide resolved
@@ -22,8 +22,6 @@ def perform_metadata_scan(ost) | |||
$log.debug "#{log_pref} VM = #{vm_name}" | |||
|
|||
args1 = ost.args[1] | |||
args1['ems'][:use_vim_broker] = MiqServer.use_broker_for_embedded_proxy?(args1['ems']['connect_to']) | |||
args1['ems'][:vim_broker_drb_uri] = MiqVimBrokerWorker.drb_uri if args1['ems'][:use_vim_broker] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the drb_uri column go away now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the miq_workers table yeah it probably can
afa3507
to
3d64c7f
Compare
3d64c7f
to
32826bc
Compare
43c0e0d
to
28b2dde
Compare
28b2dde
to
411284d
Compare
Checked commits agrare/manageiq-providers-vmware@f506ade~...411284d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/vmware/infra_manager/scanning/job.rb
app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared/scanning.rb
spec/models/manageiq/providers/vmware/infra_manager/inventory/collector_spec.rb
|
🔥 🗑 🚽 |
No description provided.