Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove the VimBrokerWorker #506

Merged
merged 5 commits into from
Jan 27, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 20, 2019

No description provided.

@Fryguy
Copy link
Member

Fryguy commented Jan 2, 2020

@agrare Can you rebase now that other PRs are merged?

@agrare agrare force-pushed the complete_removal_of_vim_broker branch 3 times, most recently from 5de716a to 8b44a71 Compare January 3, 2020 15:50
@agrare agrare force-pushed the complete_removal_of_vim_broker branch from 9d76977 to ae7a9a9 Compare January 3, 2020 17:28
@agrare agrare force-pushed the complete_removal_of_vim_broker branch from f8d123d to afa3507 Compare January 6, 2020 21:05
@@ -22,8 +22,6 @@ def perform_metadata_scan(ost)
$log.debug "#{log_pref} VM = #{vm_name}"

args1 = ost.args[1]
args1['ems'][:use_vim_broker] = MiqServer.use_broker_for_embedded_proxy?(args1['ems']['connect_to'])
args1['ems'][:vim_broker_drb_uri] = MiqVimBrokerWorker.drb_uri if args1['ems'][:use_vim_broker]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the drb_uri column go away now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the miq_workers table yeah it probably can

@agrare agrare force-pushed the complete_removal_of_vim_broker branch from afa3507 to 3d64c7f Compare January 22, 2020 19:11
@agrare agrare force-pushed the complete_removal_of_vim_broker branch from 3d64c7f to 32826bc Compare January 24, 2020 19:22
@agrare agrare force-pushed the complete_removal_of_vim_broker branch 2 times, most recently from 43c0e0d to 28b2dde Compare January 24, 2020 20:47
@agrare agrare force-pushed the complete_removal_of_vim_broker branch from 28b2dde to 411284d Compare January 24, 2020 20:57
@miq-bot
Copy link
Member

miq-bot commented Jan 24, 2020

Checked commits agrare/manageiq-providers-vmware@f506ade~...411284d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 39 offenses detected

app/models/manageiq/providers/vmware/infra_manager/scanning/job.rb

app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared/scanning.rb

  • ❗ - Line 58, Col 11 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

spec/models/manageiq/providers/vmware/infra_manager/inventory/collector_spec.rb

@Fryguy Fryguy merged commit 0802257 into ManageIQ:master Jan 27, 2020
@agrare agrare deleted the complete_removal_of_vim_broker branch January 27, 2020 15:28
@Fryguy Fryguy added this to the Sprint 129 Ending Feb 3, 2020 milestone Jan 27, 2020
@jrafanie
Copy link
Member

🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽
🔥 🗑 🚽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants