Add a common verify_creds and params_for_create #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
agrare
force-pushed
the
add_common_verify_credentials_and_params_for_create
branch
9 times, most recently
from
7e154de to
e434b3f
Compare
Fryguy
reviewed
Oct 1, 2019
| # } | ||
| # } | ||
| def self.verify_credentials(args) | ||
| default_endpoint = args.dig("endpoints", "default") |
There was a problem hiding this comment.
Do we verify the events endpoint?
There was a problem hiding this comment.
No we only verified the default endpoint
Fryguy
reviewed
Oct 1, 2019
| # } | ||
| # } | ||
| def self.verify_credentials(args) | ||
| default_endpoint = args.dig("endpoints", "default") |
There was a problem hiding this comment.
Do we need to verify the console creds?
There was a problem hiding this comment.
We don't today but we probably should
Fryguy
reviewed
Oct 1, 2019
Add a method to return DDF format params to create a vSphere provider and a method to verify the credentials. ManageIQ/manageiq#18818
agrare
force-pushed
the
add_common_verify_credentials_and_params_for_create
branch
from
e434b3f to
dc28803
Compare
|
Checked commit agrare@dc28803 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to return DDF format params to create a vSphere provider
and a method to verify the credentials.
ManageIQ/manageiq#18818