Update disk's controller type parsing #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disk controller type parsing was completely wrong, since it relied on a) parent disk b) description But there is no such thing as "parent disk", `disk.parent` actually points to "parent controller". Inventoring crashed hard when such "parent disk" was not found! With this commit we update refresh parser to now properly inventory controller type based on disk's bus subtype. Also, we prevent distinguising real disks from simple ones (like CD) based on "disk.description", which is rather unreliable, and now distinguish based on disk's bus type. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
disk-parsing
branch
from
f06d120 to
af42e32
Compare
|
Checked commit miha-plesko@af42e32 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
/cc @sasoc this may be interesting for you since you're working on graph refresh. |
agrare
approved these changes
Mar 14, 2018
simaishi
pushed a commit
that referenced
this pull request
Apr 3, 2018
Update disk's controller type parsing (cherry picked from commit 33ed4b8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563363
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…oning_spec_fix Use proper request_task subclass for provisioning spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disk controller type parsing was completely wrong, since it relied on
a) parent disk
b) description
But there is no such thing as "parent disk",
disk.parentactually points to "parent controller". Inventoring crashed hard when such "parent disk" was not found!With this commit we update refresh parser to now properly inventory controller type based on disk's bus subtype. Also, we prevent distinguising real disks from simple ones (like CD) based on "disk.description", which is rather unreliable, and now distinguish based on disk's bus type.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1553124
@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @agrare