Support update VM snapshot #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @miha-plesko |
|
@sasoc can you please add a simple unit test for this? Otherwise it looks good to me - was really strange that snapshoting got disabled after user created the first snapshot. |
sasoc
force-pushed
the
support-update-vm-snapshot
branch
from
ca71cda to
0651d7a
Compare
miha-plesko
suggested changes
Mar 5, 2018
|
|
||
| it 'supports snapshot create' do | ||
| expect(vm.supports_snapshot_create?).to be_truthy | ||
| end | ||
| end |
There was a problem hiding this comment.
Please add another test case where you first manually add one snapshot to the vm prior checking for supports_snapshot_create?. Just to make sure your supports did override the one from core.
sasoc
force-pushed
the
support-update-vm-snapshot
branch
from
0651d7a to
6e2cb29
Compare
miha-plesko
suggested changes
Mar 5, 2018
| expect(vm.supports_snapshot_create?).to be_truthy | ||
| end | ||
|
|
||
| it 'supports snapshot update' do |
There was a problem hiding this comment.
it 'supports snapshot create (for second snapshot)' do
Create new snapshot was disabled when VM already had an existing snapshot. VCloud only supports having one snapshot per VM, but you can still create new snapshot, which updates the existing one. So now VM supports `snapshot_create` even when it already has a snapshot. Signed-off-by: sasoc <[email protected]>
sasoc
force-pushed
the
support-update-vm-snapshot
branch
from
6e2cb29 to
3073ae5
Compare
|
Checked commit sasoc@3073ae5 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Mar 14, 2018
|
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1567760 @miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 16, 2018
Support update VM snapshot (cherry picked from commit ba01933) https://bugzilla.redhat.com/show_bug.cgi?id=1567962
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…approval2 Auto approval for instance resize operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new snapshot was disabled when VM already had an existing snapshot. VCloud only supports having one snapshot per VM, but you can still create new snapshot, which updates the existing one. So now VM supports
snapshot_createeven when it already has a snapshot.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1567760