Update driven refresh #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
update_driven_refresh
branch
from
2e57b29 to
ece190c
Compare
agrare
force-pushed
the
update_driven_refresh
branch
3 times, most recently
from
eb2aef6 to
45506c7
Compare
agrare
force-pushed
the
update_driven_refresh
branch
4 times, most recently
from
e22e65a to
d98fca6
Compare
agrare
force-pushed
the
update_driven_refresh
branch
from
d98fca6 to
b3049f0
Compare
agrare
force-pushed
the
update_driven_refresh
branch
2 times, most recently
from
fdc6b8a to
b43dbf7
Compare
|
Checked commits agrare/manageiq-providers-vmware@d8f0d40~...b43dbf7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
force-pushed
the
update_driven_refresh
branch
from
b43dbf7 to
ca1252f
Compare
Ladas
reviewed
Apr 4, 2018
| enabled = props["configuration.drsConfig.enabled"] | ||
| cluster_hash[:drs_enabled] = enabled.to_s.downcase == "true" | ||
| end | ||
| if props.include?("configuration.drsConfig.defaultVmBehavior") |
There was a problem hiding this comment.
so, we will set a nil, instead of not having the :key ?
There was a problem hiding this comment.
Now that we're caching the properties we don't have to worry about getting a sparse update.
When we move to not cache some properties we'll need to go back to checking for every key that we don't cache but this way I find is more readable in the meant time
Ladas
approved these changes
Apr 5, 2018
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Revert "Support TTL (Time To Live) value for services."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change takes the existing cache-less update driven refresh and cached all of the inventory in order to fix a number of issues with parsing to our schema without having all of the inventory cached.
The goal here is to get the update-driven part of this style of refresh in then work on reducing the cache footprint instead of trying to get it all in at once.
As much as was possible I took the cache code from the existing VimBroker but I added tests which it never had https://github.com/ManageIQ/manageiq-providers-vmware/pull/186/files#diff-e11e8b8028111e573bec9a54002835ff