Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken specs from EMS hostname validation and vCloud Refresh #173

Merged
merged 2 commits into from
Jan 15, 2018
Merged

Fix broken specs from EMS hostname validation and vCloud Refresh #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
621a19f
Fix broken specs from EMS hostname validation
agrare Jan 12, 2018
ff7081c
Lock down fog-core to fix vCloud specs
agrare Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions manageiq-providers-vmware.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,lib}/**/*"]

s.add_dependency("fog-vcloud-director", ["~> 0.1.8"])
s.add_dependency "fog-core", "~>1.40"
s.add_dependency "vmware_web_service", "~>0.2.4"
s.add_dependency "rbvmomi", "~>1.11.3"

Expand Down
7 changes: 1 addition & 6 deletions spec/models/manageiq/providers/vmware/infra_manager_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,6 @@
expect(@ems.remote_console_vmrc_support_known?).to be_truthy
end

it "false for missing hostname" do
@ems.update_attributes(:hostname => nil, :api_version => "5.0", :uid_ems => "2E1C1E82-BD83-4E54-9271-630C6DFAD4D1")
expect(@ems.remote_console_vmrc_support_known?).not_to be_truthy
end

it "false for blank hostname" do
@ems.update_attributes(:hostname => "", :api_version => "5.0", :uid_ems => "2E1C1E82-BD83-4E54-9271-630C6DFAD4D1")
expect(@ems.remote_console_vmrc_support_known?).not_to be_truthy
Expand Down Expand Up @@ -135,7 +130,7 @@
end

it "will restart EventCatcher when hostname changes" do
@ems.update_attributes(:hostname => "something else")
@ems.update_attributes(:hostname => "something-else")
assert_event_catcher_restart_queued
end

Expand Down