Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSA connect to use :hostname or :ipaddress instead of :address #143

Merged
merged 1 commit into from
Nov 28, 2017
Merged

SSA connect to use :hostname or :ipaddress instead of :address #143

merged 1 commit into from
Nov 28, 2017

Conversation

jameswnl
Copy link
Contributor

@jameswnl
Copy link
Contributor Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Nov 27, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 27, 2017

Checked commit https://github.com/jameswnl/manageiq-providers-vmware/commit/694e6f18865c111735e4d31fb54a98ad9ba66b64 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare self-assigned this Nov 27, 2017
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare merged commit 694e6f1 into ManageIQ:master Nov 28, 2017
agrare added a commit that referenced this pull request Nov 28, 2017
SSA connect to use :hostname or :ipaddress instead of :address
@agrare agrare added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 28, 2017
@jameswnl
Copy link
Contributor Author

@miq-bot add_labels gaprindashvili/yes

@jameswnl jameswnl deleted the ssa-use-addr branch November 28, 2017 19:33
simaishi pushed a commit that referenced this pull request Nov 29, 2017
SSA connect to use :hostname or :ipaddress instead of :address

(cherry picked from commit 4feac2c)

https://bugzilla.redhat.com/show_bug.cgi?id=1518775
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 3b758afb8bccc837f4adae0da9dfd2fec8f951eb
Author: Adam Grare <[email protected]>
Date:   Tue Nov 28 08:55:12 2017 -0500

    Merge pull request #143 from jameswnl/ssa-use-addr
    
    SSA connect to use :hostname or :ipaddress instead of :address
    
    (cherry picked from commit 4feac2ca97c009e309d396b0eb5bbd2b790482ab)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518775

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
v2v: Fix filtering of drivers ISO to display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants