Fix RefreshWorker before_exit arguments #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The before_exit method takes two arguments, message and exit code. The method in the vmware refresh_worker didn't take any arguments and led to this exception when shutting down: ``` MIQ(ManageIQ::Providers::Vmware::InfraManager::RefreshWorker::Runner) ID [25] PID [9366] GUID [4e2d7762-cbb8-486f-aeb7-fb441c08aaea] Error in before_exit: wrong number of arguments (given 2, expected 0) ``` This would only cause an issue if you were using the update driven refresh (not default) and in that case the thread would be terminated instead of cleanly shut down.
|
Checked commit agrare@47300e2 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
cc @blomquisg |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Fix RefreshWorker before_exit arguments (cherry picked from commit 64720ef)
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…olumes Added cloud volumes to requested resource calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The before_exit method takes two arguments, message and exit code. The
method in the vmware refresh_worker didn't take any arguments and led to
this exception when shutting down:
This would only cause an issue if you were using the update driven
refresh (not default) and in that case the thread would be terminated
instead of cleanly shut down.