Move saving of ems.api_version back to parser #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we moved saving the api_version to save_inventory we started getting periodic errors in provisioning when checking ext_management_system.api_version > '5.5' api_version would be nil. https://bugzilla.redhat.com/show_bug.cgi?id=1503281
|
Checked commit agrare@4ed8b98 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
@blomquisg tested this with @lkhomenk and he confirmed this resolves the issue |
|
cc @blomquisg |
Ladas
approved these changes
Nov 21, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Move saving of ems.api_version back to parser (cherry picked from commit bc7a70d) https://bugzilla.redhat.com/show_bug.cgi?id=1517837
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Added --no-deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved saving the api_version to save_inventory we started
getting periodic errors in provisioning when checking
ext_management_system.api_version > '5.5' api_version would be nil.
https://bugzilla.redhat.com/show_bug.cgi?id=1503281