Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to return all valid SCSI Controller Types #126

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 25, 2017

This can be used by the UI to ask for what valid controller types are.

The types are defined by https://www.vmware.com/support/developer/vc-sdk/visdk41pubs/ApiReference/vim.vm.device.VirtualSCSIController.html

Blocks: ManageIQ/manageiq-ui-classic#2494

@miq-bot
Copy link
Member

miq-bot commented Oct 25, 2017

Checked commit agrare@ecc2b90 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member Author

agrare commented Oct 25, 2017

@blomquisg can you review?

@blomquisg blomquisg merged commit 869ded0 into ManageIQ:master Oct 26, 2017
@blomquisg blomquisg added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@agrare agrare deleted the add_method_to_list_scsi_controller_types branch October 26, 2017 16:28
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Update method order_ansible_playbook.rb to match the move of create_service_provision_request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants