Login with console authentication if available

[agrare]

Allow different credentials for connecting to a vmware console.
Passing :console will fallback to standard credentials if they are missing.

[agrare]

cc @skateman

[skateman]

@agrare I think we'd need a supports authentication type thingie in the same PR

[agrare]

@skateman 👍 added, PTAL

[skateman]

[agrare]

@blomquisg this is ready can you review?

[skateman]

@agrare @blomquisg I tested this and it works as expected 🎉
But, what happens if these credentials aren't specified? Does it fall back to the default ones?

[blomquisg]

@skateman, @agrare said:

Passing :console will fallback to standard credentials if they are missing.

@agrare is there a test you can add for that?

[agrare]

@agrare is there a test you can add for that?

@blomquisg it was a little gross because we actually only get the username and password wayyyy down in MiqFaultTolerantVim but yes, there is :)

[miq-bot]

Checked commits agrare/manageiq-providers-vmware@e2ed49c~...6818be1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

Okay @blomquisg new test is 🍏 :)

[simaishi]

@agrare Is there a BZ for this?

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit f07dd9e142089620f9565af470ceb0a6de4d7085
Author: Greg Blomquist <[email protected]>
Date:   Thu Nov 2 16:13:44 2017 -0400

    Merge pull request #125 from agrare/add_option_for_console_authentication
    
    Login with console authentication if available
    (cherry picked from commit f8943a1fcc8c85ec01c2ff440611609b180449fb)

[simaishi]

Fine backport details:

$ git log -1
commit c341956f132e54d1be96393688abca99e6971d98
Author: Greg Blomquist <[email protected]>
Date:   Thu Nov 2 16:13:44 2017 -0400

    Merge pull request #125 from agrare/add_option_for_console_authentication
    
    Login with console authentication if available
    (cherry picked from commit f8943a1fcc8c85ec01c2ff440611609b180449fb)