Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parent collections for hardwares/disks #116

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 27, 2017

VMware has the vms_and_templates inventory collection not vms +
miq_templates so we need to update the hardware and disks accordingly
otherwise we get the error:

[RuntimeError]: Can't find InventoryCollection vms from InventoryCollection:<Disk>

VMware has the vms_and_templates inventory collection not vms +
miq_templates so we need to update the hardware and disks accordingly
otherwise we get the error:

```
[RuntimeError]: Can't find InventoryCollection vms from InventoryCollection:<Disk>
```
@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2017

Checked commit agrare@83fd9e7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@Ladas Ladas self-assigned this Sep 27, 2017
@Ladas Ladas added the bug label Sep 27, 2017
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it make sense.

@Ladas Ladas merged commit e82dea2 into ManageIQ:master Sep 27, 2017
@Ladas Ladas added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 27, 2017
@agrare agrare deleted the fix_hardwares_and_disks_parent_collections branch September 27, 2017 18:21
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants