Split on comma instead of CSV.parse for metrics capture #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
split_on_comma_instead_of_csv
branch
from
aacd40e to
055ffe5
Compare
agrare
force-pushed
the
split_on_comma_instead_of_csv
branch
from
fdedd3e to
0c3f9a2
Compare
|
Checked commits agrare/manageiq-providers-vmware@055ffe5~...0c3f9a2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
changed the title
|
@Fryguy I added a check to see if there were any quotes and fallback to |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Ensure spec/support from ManageIQ::AutomationEngine is loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split on commas instead of the full
CSV.parse()which is more general but also much slower.There are two values that are returned in CSV,
sampleInfoCSVandvaluedefined here EntityMetricCSVThe SampleInfo contains a
xsd:intand axsd:dateTimewhich looks like:sampleInfoCSV: 20,2011-08-12T20:33:20Z,20,2011-08-12T20:33:40Z,.....The PerfMetricIntSeries contains an array of
xsd:longand looks like:value: 0,0,0,3,0,1273,1099,0,0,0,0,0,0,...Both of these should be safe to split on commas and save the overhead of
CSV.parse()Depends: