Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validation code to VimConnectMixin #104

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Aug 31, 2017

Adding validation code to VimConnectMixin to reuse code that is needed in new raw_connect method for the Vmware infra manager

@miq-bot add_label wip

@miq-bot
Copy link
Member

miq-bot commented Aug 31, 2017

Checked commit jntullo@201ec4a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare self-assigned this Sep 5, 2017
@agrare agrare removed the wip label Sep 13, 2017
@agrare agrare changed the title [WIP] Move validation code to VimConnectMixin Move validation code to VimConnectMixin Sep 13, 2017
@agrare agrare merged commit 8b813e1 into ManageIQ:master Sep 13, 2017
@agrare agrare added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 13, 2017
agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this pull request Apr 15, 2019
Change exceeds message in log to warn type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants