Skip to content

Commit

Permalink
Merge pull request #173 from agrare/fix_infra_manager_spec_tests
Browse files Browse the repository at this point in the history
Fix broken specs from EMS hostname validation and vCloud Refresh
(cherry picked from commit e017119)
  • Loading branch information
blomquisg authored and simaishi committed Jan 15, 2018
1 parent 0f1be92 commit f6792d7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
1 change: 1 addition & 0 deletions manageiq-providers-vmware.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,lib}/**/*"]

s.add_dependency("fog-vcloud-director", ["~> 0.1.8"])
s.add_dependency "fog-core", "~>1.40"
s.add_dependency "vmware_web_service", "~>0.2.4"
s.add_dependency "rbvmomi", "~>1.11.3"

Expand Down
7 changes: 1 addition & 6 deletions spec/models/manageiq/providers/vmware/infra_manager_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,6 @@
expect(@ems.remote_console_vmrc_support_known?).to be_truthy
end

it "false for missing hostname" do
@ems.update_attributes(:hostname => nil, :api_version => "5.0", :uid_ems => "2E1C1E82-BD83-4E54-9271-630C6DFAD4D1")
expect(@ems.remote_console_vmrc_support_known?).not_to be_truthy
end

it "false for blank hostname" do
@ems.update_attributes(:hostname => "", :api_version => "5.0", :uid_ems => "2E1C1E82-BD83-4E54-9271-630C6DFAD4D1")
expect(@ems.remote_console_vmrc_support_known?).not_to be_truthy
Expand Down Expand Up @@ -135,7 +130,7 @@
end

it "will restart EventCatcher when hostname changes" do
@ems.update_attributes(:hostname => "something else")
@ems.update_attributes(:hostname => "something-else")
assert_event_catcher_restart_queued
end

Expand Down

0 comments on commit f6792d7

Please sign in to comment.