Add computer systems to inventory #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am marking this pull request as wip since needs ManageIQ/manageiq#17557 merged first. @miq-bot add_label wip |
miq-bot
changed the title
Since computer systems are in 1:1 relation with the physical servers and carry no data on its own, we add them to the database at the same time as the servers.
tadeboro
force-pushed
the
store-computer-systems
branch
from
3d5721d to
260a668
Compare
|
Checked commit xlab-si@260a668 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot remove_label wip |
miq-bot
changed the title
gberginc
approved these changes
Jun 12, 2018
| @@ -24,6 +24,7 @@ def assert_ems | |||
| expect(ems.physical_servers.count).to eq(1) | |||
| expect(ems.physical_servers.map(&:ems_ref)).to match_array([server_id]) | |||
| expect(ems.physical_server_details.count).to eq(1) | |||
| expect(ems.computer_systems.count).to eq(1) | |||
There was a problem hiding this comment.
Should there be a simple assert for the computer_system?
There was a problem hiding this comment.
I did not add it because there is not much to check here, since ComputerSystem model only contains two fields: id and type of its managed entity. I can check if those fields match the server's, but this only checks if the refresh system is working as expected and has nothing to do with Redfish provider.
agrare
approved these changes
Jun 13, 2018
agrare
added a commit
that referenced
this pull request
Jun 13, 2018
Add computer systems to inventory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since computer systems are in 1:1 relation with the physical servers
and carry no data on its own, we add them to the database at the same
time as the servers.
@miq-bot assign @gtanzillo
@miq-bot add_reviewer @gberginc
@miq-bot add_reviewer @matejart