Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location LED operations #7

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

tadeboro
Copy link
Contributor

@tadeboro tadeboro commented Jun 8, 2018

These operations are triggered by identify menu actions in the UI.

@miq-bot assign @gtanzillo
@miq-bot add_reviewer @gberginc @matejart

@miq-bot
Copy link
Member

miq-bot commented Jun 8, 2018

@tadeboro 'gberginc matejart' is an invalid reviewer, ignoring...

@tadeboro
Copy link
Contributor Author

tadeboro commented Jun 8, 2018

@miq-bot add_reviewer @gberginc
@miq-bot add_reviewer @matejart

@miq-bot miq-bot requested review from gberginc and matejart June 8, 2018 08:48
These operations are triggered by identify menu actions in the UI.
@tadeboro tadeboro force-pushed the location-led-operations branch from 9263013 to e3b0606 Compare June 8, 2018 09:02
Copy link
Contributor

@gberginc gberginc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@miq-bot
Copy link
Member

miq-bot commented Jun 8, 2018

Checked commit xlab-si@e3b0606 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

Copy link

@matejart matejart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare merged commit 5263636 into ManageIQ:master Jun 8, 2018
@agrare agrare added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 8, 2018
@agrare agrare added the enhancement New feature or request label Jun 8, 2018
@tadeboro tadeboro deleted the location-led-operations branch June 11, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants