Replace test data #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old test data was missing quite a few pieces of information, which made it hard to test the inventory refresh process thoroughly. New set of data contains data of better quality: * has more than one server, * servers actually contain some disks, * servers are placed in racks/chassis, * chassis are nested, * components contains location data.
tadeboro
force-pushed
the
replace-test-data
branch
from
9b52210 to
cfbf65f
Compare
|
Checked commit xlab-si@cfbf65f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
@tadeboro can you look at the spec failure? |
agrare
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old test data was missing quite a few pieces of information, which made it hard to test the inventory refresh process thoroughly.
New set of data contains data of better quality:
Depends on #31