Fix service_url when using ssl-no-validation #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the URL to use we were checking for non-ssl, ssl-with-validation, and ssl as the protocol. Rather than ssl the DDF form uses ssl-no-validation which was causing the scheme to be nil and making it impossible to add the provider.
|
Checked commit agrare@ad1baec with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jun 6, 2022
Fix service_url when using ssl-no-validation (cherry picked from commit 57a71d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the URL to use we were checking for non-ssl, ssl-with-validation, and ssl as the protocol. Rather than ssl the DDF form uses ssl-no-validation which was causing the scheme to be nil and making it impossible to add the provider (ref https://github.com/ManageIQ/manageiq-providers-redfish/blob/master/app/models/manageiq/providers/redfish/manager_mixin.rb#L55-L68)
Fixes ManageIQ/manageiq#21897