Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EventTargetParser looking for string keys #51

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix EventTargetParser looking for string keys #51

merged 1 commit into from
Jun 28, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Jun 27, 2024 •
edited by Fryguy
Loading

@agrare agrare added bug Something isn't working radjabov/yes? labels Jun 27, 2024
@agrare agrare requested a review from Fryguy as a code owner June 27, 2024 16:20
@agrare agrare mentioned this pull request Jun 27, 2024
Merged
@miq-bot
Copy link
Member

miq-bot commented Jun 27, 2024

Checked commit agrare@649dd20 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member Author

agrare commented Jun 27, 2024

@miq-bot cross-repo-tests ManageIQ/manageiq-providers-ovirt#671

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jun 27, 2024
@agrare @miq-bot
Running tests for agrare
da6e959 
From Pull Request:  ManageIQ/manageiq-providers-red_hat_virtualization#51
@miq-bot miq-bot mentioned this pull request Jun 27, 2024
Closed
@Fryguy Fryguy merged commit a9ad070 into ManageIQ:master Jun 28, 2024
2 of 4 checks passed
@Fryguy Fryguy self-assigned this Jun 28, 2024
@agrare agrare deleted the fix_event_target_parser_event_string_keys branch June 28, 2024 17:25
@Fryguy
Copy link
Member

Fryguy commented Jul 9, 2024

Backported to radjabov in commit 099d5df.

commit 099d5dfd35c2ab3ddd083e4a02e572f029d71076
Author: Jason Frey <[email protected]>
Date:   Fri Jun 28 13:24:19 2024 -0400

    Merge pull request #51 from agrare/fix_event_target_parser_event_string_keys
    
    Fix EventTargetParser looking for string keys
    
    (cherry picked from commit a9ad07031e6742b097f97db3c737137e5e876def)

Fryguy added a commit that referenced this pull request Jul 9, 2024
@Fryguy
Merge pull request #51 from agrare/fix_event_target_parser_event_stri…
099d5df 
…ng_keys

Fix EventTargetParser looking for string keys

(cherry picked from commit a9ad070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@Fryguy Fryguy

Labels
bug Something isn't working radjabov/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @Fryguy