Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable delete button for the active snapshot on oVirt #54

Merged
merged 1 commit into from
Jul 2, 2017
Merged

Disable delete button for the active snapshot on oVirt #54

merged 1 commit into from
Jul 2, 2017

Conversation

borod108
Copy link
Contributor

@borod108 borod108 commented Jun 29, 2017 •
edited
Loading

Disable the delete button when the active snapshot is selected
for a vm on oVirt.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1443411

Required for: ManageIQ/manageiq-ui-classic#1628

Disable delete button for the active snapshot on oVirt
ce6055c 
Disable the delete button when the active snapshot is selected
for a vm on oVirt.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1443411
@borod108 borod108 mentioned this pull request Jun 29, 2017
Merged
@borod108
Copy link
Contributor Author

@masayag can you please review?

@miq-bot
Copy link
Member

miq-bot commented Jun 29, 2017

Checked commit borod108@ce6055c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@borod108
Copy link
Contributor Author

borod108 commented Jul 2, 2017

@miq-bot assign @oourfali
can you please merge?

@oourfali oourfali merged commit 9aaf467 into ManageIQ:master Jul 2, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2017

Marking as fine/yes as ManageIQ/manageiq-ui-classic#1628 is fine/yes and depends on this PR.

@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit 83d576ffc2a929d85e99d2d5d7f5817000c2fd58
Author: Oved Ourfali <[email protected]>
Date:   Sun Jul 2 11:09:43 2017 +0300

    Merge pull request #54 from borod108/bugs/delete_active_snapshot
    
    Disable delete button for the active snapshot on oVirt
    (cherry picked from commit 9aaf4672f213786d2332f8deea2c5c2bfb3eb95d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1480377

@borod108 borod108 deleted the bugs/delete_active_snapshot branch December 4, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masayag masayag masayag approved these changes

Assignees

@oourfali oourfali

Labels
fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borod108 @miq-bot @simaishi @masayag @oourfali