Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled exception in metrics collection when missing credentials #53

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

borod108
Copy link
Contributor

When trying to collect C&U data from an Ovirt provider with missing credentials a warning will
be shown in the log but no exception will be risen.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1450644

@borod108
Copy link
Contributor Author

@masayag please review
@miq-bot add_label fine/yes

@borod108
Copy link
Contributor Author

When trying to collect C&U data from an Ovirt provider with missing credentials a warning will
be shown in the log but no exception will be risen.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1450644
@borod108 borod108 force-pushed the bugs/metrics_error_in_logs branch from 480f427 to 32de2aa Compare June 29, 2017 05:59
@miq-bot
Copy link
Member

miq-bot commented Jun 29, 2017

Checked commit borod108@32de2aa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@masayag
Copy link
Contributor

masayag commented Jun 29, 2017

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Jun 29, 2017
@borod108
Copy link
Contributor Author

@miq-bot assign @oourfali

can you please merge?

@oourfali oourfali merged commit 4c6fc3c into ManageIQ:master Jun 29, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport (to manageiq repo) details:

$ git log -1
commit 02ec1f4d3882a7b63a6325c5e46fb4a3658c1ec1
Author: Oved Ourfali <[email protected]>
Date:   Thu Jun 29 09:52:16 2017 +0300

    Merge pull request #53 from borod108/bugs/metrics_error_in_logs
    
    Fix unhandled exception in metrics collection when missing credentials
    (cherry picked from commit 4c6fc3c5ec34798935337028ef06621012c37bd1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478421

@borod108 borod108 deleted the bugs/metrics_error_in_logs branch December 4, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants