Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement :reboot_guest for VM #52

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Implement :reboot_guest for VM #52

merged 1 commit into from
Jun 26, 2017

Conversation

matobet
Copy link
Contributor

@matobet matobet commented Jun 23, 2017

@matobet matobet changed the title Implement :reboot_guest for VM Implement :reboot_guest for VM Jun 23, 2017
@matobet matobet changed the title Implement :reboot_guest for VM Implement :reboot_guest for VM Jun 23, 2017
@matobet
Copy link
Contributor Author

matobet commented Jun 23, 2017

@miq-bot assign @borod108

@matobet
Copy link
Contributor Author

matobet commented Jun 23, 2017

@jhernand @borod108 please review

@miq-bot
Copy link
Member

miq-bot commented Jun 23, 2017

Checked commit matobet@989b055 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 2 offenses detected

app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v3.rb

app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb

@oourfali oourfali merged commit 5f46e1d into ManageIQ:master Jun 26, 2017
@simaishi
Copy link
Contributor

@matobet @oourfali can this PR be fine/yes?

@oourfali
Copy link
Contributor

@miq-bot add_label fine/yes

@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport (to manageiq repo) details:

$ git log -1
commit 597ada0ae7f153d19e8120ab60920bb4425a96f6
Author: Oved Ourfali <[email protected]>
Date:   Mon Jun 26 13:33:52 2017 +0300

    Merge pull request #52 from matobet/master
    
    Implement :reboot_guest for VM
    (cherry picked from commit 5f46e1d4c1f035ad314f15c2f78868bf04b7ddad)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borod108 borod108 borod108 approved these changes

@jhernand jhernand jhernand approved these changes

Assignees

@borod108 borod108

Labels
fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matobet @miq-bot @simaishi @oourfali @jhernand @borod108