Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-Driven create params and validate_credentials #408

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 6, 2019

Add a data-driven-forms params_for_create allowing dynamic API driven
UI form building and add the standard validate_credentials API.

@agrare
Copy link
Member Author

agrare commented Sep 6, 2019

@borod108 we're working on allowing the API to drive what the UI forms required to add a provider requires. Can you review this to check that I have what is required/optional and the types correct for raw_connect?
cc @skateman

@agrare agrare force-pushed the add_data_driven_params_for_create_and_validate_credentials branch from 203d7df to 7d785e0 Compare September 6, 2019 18:44
@borod108
Copy link
Contributor

borod108 commented Sep 9, 2019

@agrare this is a cool change :)
We do need to have RSA key pair creds as well.
(They were add here: ManageIQ/manageiq-ui-classic#3983)

@agrare
Copy link
Member Author

agrare commented Sep 9, 2019

Thanks @borod108, is this another endpoint or just another authentication type?

@borod108
Copy link
Contributor

@agrare just an authentication type as far as I understand.

Add a data-driven-forms params_for_create allowing dynamic API driven
UI form building and add the standard validate_credentials API.
@agrare agrare force-pushed the add_data_driven_params_for_create_and_validate_credentials branch from 7d785e0 to a6bd6b7 Compare September 12, 2019 17:33
@agrare
Copy link
Member Author

agrare commented Sep 12, 2019

Okay @borod108 added PTAL

@miq-bot
Copy link
Member

miq-bot commented Sep 12, 2019

Checked commits agrare/manageiq-providers-ovirt@6b824a4~...a6bd6b7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@borod108
Copy link
Contributor

LGTM

@borod108 borod108 merged commit 0895270 into ManageIQ:master Sep 18, 2019
@agrare agrare added this to the Sprint 121 Ending Sep 30, 2019 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants