[wip]Upgrade Ovirt Cluster through Ansibel #304
Conversation
borod108
changed the title
| engine_user: connect_options[:username], | ||
| engine_password: connect_options[:password], | ||
| cluster_name: name, | ||
| hostname: "localhost" |
There was a problem hiding this comment.
yes it runs on local host. the target is defined in the engine_url.
| engine_url: url, | ||
| engine_user: connect_options[:username], | ||
| engine_password: connect_options[:password], | ||
| cluster_name: name, |
There was a problem hiding this comment.
I do not see name being defined. Is it defined in super class?
There was a problem hiding this comment.
yes, in EmsCluster
|
@borod108 typo in header - Ansibel |
borod108
force-pushed
the
rfe/ansible_cluster_upgrade
branch
2 times, most recently
from
00431af to
81a6b20
Compare
borod108
changed the title
|
@pkliczewski @masayag will you please review and merge? |
borod108
force-pushed
the
rfe/ansible_cluster_upgrade
branch
from
81a6b20 to
78284d6
Compare
|
@borod108 Please make sure that Travis is happy. |
borod108
force-pushed
the
rfe/ansible_cluster_upgrade
branch
2 times, most recently
from
5b10155 to
5f684e9
Compare
| @ems = FactoryGirl.create(:ems_redhat_with_authentication) | ||
| @cluster = FactoryGirl.create(:ems_cluster_redhat, :ems_id => @ems.id) | ||
| my_server = double("my_server", :guid => "guid1") | ||
| allow(MiqServer).to receive(:my_server).and_return(my_server) |
There was a problem hiding this comment.
What receive(:my_server) stands for ? it doesn't seems like a method name
There was a problem hiding this comment.
It is a method name, it is used here to put a task into MiqQueue: https://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/ansible_runner_workflow.rb#L72
Add method to upgrade cluster using ovirt-ansible-cluster-upgrade role.
borod108
force-pushed
the
rfe/ansible_cluster_upgrade
branch
from
5f684e9 to
9df4a8a
Compare
|
@borod108 there's a typo in header |
borod108
force-pushed
the
rfe/ansible_cluster_upgrade
branch
from
e21f22b to
e9ea47c
Compare
|
Checked commits borod108/manageiq-providers-ovirt@9df4a8a~...e9ea47c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
borod108
changed the title
|
@agrare @Ladas so I manged to make it work, without moving the ems_cluster code to the core repo. So everything seems to work fine, but because we do not really have sit for ems cluster I would like you to review and tell me if it is ok to leave it like this. (The solution was setting the class_model to ::EmsCluster) |
|
@borod108 hm, and does it store the right :type into EmsCluster record? I'd say it will not store the ManageIQ::Providers::Redhat::InfraManager::EmsCluster? |
| @@ -0,0 +1,29 @@ | |||
| class ManageIQ::Providers::Redhat::InfraManager::EmsCluster < ::EmsCluster | |||
There was a problem hiding this comment.
@borod108 lets try to define this as
module ManageIQ
module Providers
module Redhat
class InfraManager
class EmsCluster < ::EmsCluster
end
end
end
end
end
| @@ -24,7 +24,9 @@ def initialize_infra_inventory_collections | |||
| # --- IC groups definitions --- | |||
|
|
|||
| def add_clusters_group | |||
| add_collection(infra, :ems_clusters) | |||
| add_collection(infra, :ems_clusters) do |builder| | |||
| builder.add_properties(:model_class => ::EmsCluster) | |||
There was a problem hiding this comment.
@borod108 and with the nested definition ^, lets try
:model_class => ManageIQ::Providers::Redhat::InfraManager::EmsCluster
and then verify it stores the right :type into the DB
|
Have to close this PR and move it to core, since EmsCluster does not have sti. |
Add method to upgrade cluster using ovirt-ansible-cluster-upgrade role.
Depends on: ManageIQ/manageiq#18108