Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attach_floppy to pass "floppy" type #298

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

borod108
Copy link
Contributor

The type of the payload was not passed.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1613326

@borod108 borod108 added the wip label Oct 10, 2018
@borod108
Copy link
Contributor Author

Marked as wip as I am not sure it is the actual problem - the vm still won't start but the xml in the ovirt log looks right. still investigating.

@pkliczewski pkliczewski merged commit db724df into ManageIQ:master Oct 10, 2018
simaishi pushed a commit that referenced this pull request Oct 11, 2018
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 55fa5965245121a0e1e7451a0e844d4d4405158f
Author: Piotr Kliczewski <[email protected]>
Date:   Wed Oct 10 16:42:36 2018 +0200

    Merge pull request #298 from borod108/bugs/1613326iso_prov_2
    
    Fix attach_floppy to pass "floppy" type
    
    (cherry picked from commit db724df0af9fe3e9dd8fbb136807c2967cbc3cbd)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1613326

simaishi pushed a commit that referenced this pull request Oct 11, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit cc975a02f4e985772f13d8db24000fd797f0fe8b
Author: Piotr Kliczewski <[email protected]>
Date:   Wed Oct 10 16:42:36 2018 +0200

    Merge pull request #298 from borod108/bugs/1613326iso_prov_2
    
    Fix attach_floppy to pass "floppy" type
    
    (cherry picked from commit db724df0af9fe3e9dd8fbb136807c2967cbc3cbd)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1637185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants