Use core's disconnect hook #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeboro
force-pushed
the
provider-disconnect
branch
from
f64a0e4 to
059e78e
Compare
Support for disconnecting after an operation is now in the core, so there is no need to copy-paste the whole with_provider_connection function anymore.
tadeboro
force-pushed
the
provider-disconnect
branch
from
059e78e to
9fabaec
Compare
|
Checked commit xlab-si@9fabaec with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
pkliczewski
approved these changes
Sep 14, 2018
pkliczewski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for disconnecting after an operation is now in the core, so there is no need to copy-paste the whole with_provider_connection function anymore.
Depends on ManageIQ/manageiq#17959
@miq-bot add_label wip