Update Ovirt for the new switch modeling #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Checked commit agrare@deb9a84 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
pkliczewski
reviewed
May 15, 2018
| @@ -145,6 +145,7 @@ def self.host_inv_to_hashes(inv, ems_inv, cluster_uids, _storage_uids) | |||
| :ems_cluster => cluster_uids[host_inv.attributes.fetch_path(:cluster, :id)], | |||
| :hardware => hardware, | |||
| :switches => switches, | |||
| :host_switches => switches, | |||
There was a problem hiding this comment.
Would be great to be consistent with naming. We use host_virtual_switches everywhere except of here. What do you think about making it consistent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Ovirt refresh_parser and graph refresh parsing/persister for the split out host-local switch model.
Depends on: ManageIQ/manageiq#17420