Provide max memory on VM reconfigure

[masayag]

Since ManageIQ doesn't support max memory, there is a need to provider a
value for it when modifying the vm memory limit.

The max memory will be calculated as follow:

1. Fetch actual VM from RHV to get current max memory
2. If new actual memory is higher than existing max memory, the max memory will
   be updated as well:
   a. If actual memory is lesser than 1 TB, then set max memory to 4 * actual memory
   b. If actual memory equals or greater than 1TB, set max memory the same value as
   actual memory

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534520

[miq-bot]

Checked commit masayag@42bfd8a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb

• ❗ - Line 727, Col 44 - Style/IfInsideElse - Convert if nested inside else to elsif.

[pkliczewski]

With this code if supports_max is false the value here will be nil. Should we not set it at all here?

[masayag]

the .compact at the end of the hash will remove it from the map if the value is null.
The alternative is extracting it into a local variable and add 'max' conditionally which will add complexity to this method.

[pkliczewski]

Same as above

[masayag]

@miq-bot add_labels bug, gaprindashvili/yes

[simaishi]

@masayag The BZ has 5.8.z flag, can/should this go to Fine branch too?

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 35714ffa953a8aa586f6292da1cbeee84fe13dd0
Author: Piotr Kliczewski <[email protected]>
Date:   Thu Mar 8 13:31:44 2018 +0100

    Merge pull request #224 from masayag/specify_max_memory
    
    Provide max memory on VM reconfigure
    (cherry picked from commit a3c14af086a7012d4e139e0f25121ae547026883)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553384

[mwperina]

The BZ has 5.8.z flag, can/should this go to Fine branch too?

Yes, please backport also to 5.8 Satoe. Thanks
@simaishi

[simaishi]

@masayag The VM reconfigure spec (#22) isn't in Fine branch, and this is conflicting. Should I backport PR 22, or just add describe "#vm_reconfigure" along with before part?

[masayag]

@borod108 Do you see any issue with backporting #22 to FINE branch ? It looks safe to me to backport it, but I'd like to be certain about it.

[borod108]

I think it is ok. And I think we have enough specs to feel somewhat comfortable.

…

On Tue, Apr 10, 2018, 11:33 AM Moti Asayag ***@***.***> wrote: @borod108 <https://github.com/borod108> Do you see any issue with backporting #22 <#22> to FINE branch ? It looks safe to me to backport it, but I'd like to be certain about it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#224 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADH369TsInoRJwfCMJIGM6p4V5FP_1uJks5tnEszgaJpZM4SidDl> .

[masayag]

@masayag The VM reconfigure spec (#22) isn't in Fine branch, and this is conflicting. Should I backport PR 22, or just add describe "#vm_reconfigure" along with before part?

@simaishi according to Boris, it is safe to backport #22 as well. So please backport both to fine.

[simaishi]

Fine backport (to manageiq repo) details:

$ git log -1
commit ef06120834f7ef7c39c7e98c715d953bac1935be
Author: Piotr Kliczewski <[email protected]>
Date:   Thu Mar 8 13:31:44 2018 +0100

    Merge pull request #224 from masayag/specify_max_memory
    
    Provide max memory on VM reconfigure
    (cherry picked from commit a3c14af086a7012d4e139e0f25121ae547026883)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565358