Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery namespace change #209

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Discovery namespace change #209

merged 1 commit into from
Feb 15, 2018

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Feb 14, 2018 •
edited
Loading

Reflect change in Discovery core introduced in ManageIQ/manageiq#16994.

@gildub gildub mentioned this pull request Feb 14, 2018
Closed
14 tasks
@gildub
Copy link
Contributor Author

gildub commented Feb 14, 2018

@d-m-u, @kbrock could you please review ASAP in order to walk away from the dual name space collusion?

@mwperina
Copy link

@masayag @borod108

@gildub gildub mentioned this pull request Feb 15, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit https://github.com/gildub/manageiq-providers-ovirt/commit/8f671936acf54649288af5f7a33376859f00fc05 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@borod108 borod108 merged commit 1213753 into ManageIQ:master Feb 15, 2018
@gildub gildub deleted the discovery_core_change branch February 15, 2018 11:37
@jrafanie
Copy link
Member

👍

borod108 added a commit to borod108/manageiq-providers-ovirt that referenced this pull request Feb 26, 2018
@borod108
Merge pull request ManageIQ#209 from gildub/discovery_core_change
de22d89 
Discovery namespace change
@agrare agrare added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 27, 2018
@gildub
Copy link
Contributor Author

gildub commented Mar 6, 2018

@miq-bot add_label gaprindashvili/yes

@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

@gildub ManageIQ/manageiq#16994 isn't marked as gaprindashvili/yes. Not sure if ManageIQ/manageiq#16994 should also go to gaprindashvili, or this should be changed to gaprindashvili/no...

@gildub
Copy link
Contributor Author

gildub commented Mar 8, 2018

@simaishi, I've added the missing ones per https://bugzilla.redhat.com/show_bug.cgi?id=1552665. Thanks

simaishi pushed a commit that referenced this pull request Mar 8, 2018
@borod108 @simaishi
Merge pull request #209 from gildub/discovery_core_change
b26d5d9 
Discovery namespace change
(cherry picked from commit 1213753)

https://bugzilla.redhat.com/show_bug.cgi?id=1552665
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit b26d5d907b80020315b99cc4d5ac4efee8fa8115
Author: Boris Od <[email protected]>
Date:   Thu Feb 15 11:44:59 2018 +0200

    Merge pull request #209 from gildub/discovery_core_change
    
    Discovery namespace change
    (cherry picked from commit 1213753f82fcc3f783b41bbc1363107d158d060a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borod108 borod108 borod108 approved these changes

Assignees
No one assigned
Labels
gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gildub @mwperina @miq-bot @jrafanie @simaishi @borod108 @agrare