Fix version check in supports_admin_ui method #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version_higher_than was renamed to version_at_least Signed-off-by: Vojtech Szocs <[email protected]>
masayag
approved these changes
Nov 27, 2017
|
Checked commit vojtechszocs@bac427f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@Fryguy see comment #133 (comment) Backporting this PR alone will cause gaprindashvili to break. If wishes to backport it, #143 must be backported as well, since the current PR depends on it. We can also not backport neither of them. But the two are depended on each other. |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Fix version check in supports_admin_ui method (cherry picked from commit 3c7ebee)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version_higher_thanwas renamed toversion_at_leastvia another PR and I forgot to sync with code that implements theadmin_uifeature 😞Depends on #143