Avoid NoMethod error in TemplatePreloadedAttributesDecorator.new #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the constructor of the 'TemplatePreloadedAttributesDecorator' class receives a parameter that defaults to 'nil', and that it is actually never used. But the implementation of the constructor tries call methods on it, 'NoMethodError'. The net result is that refresh fails. To avoid that this patch removes that unused parameter. This patch addresses the following issue: RHV Refresh worker throwing error in evm.log https://bugzilla.redhat.com/1501162 Signed-off-by: Juan Hernandez <[email protected]>
|
@borod108 please review. |
|
Checked commit https://github.com/jhernand/manageiq-providers-ovirt/commit/2d0a6d3fad4dc6d1e245f64c5f1596a9c9d64cad with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
borod108
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the constructor of the
TemplatePreloadedAttributesDecoratorclass receives a parameter that defaults to 'nil', and that it is
actually never used. But the implementation of the constructor tries
call methods on it,
NoMethodError. The net result is that refreshfails. To avoid that this patch removes that unused parameter.
This patch addresses the following issue:
RHV Refresh worker throwing error in evm.log
https://bugzilla.redhat.com/1501162