Check provisioning status with the correct tenant scoping #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petrblaho @aufi it would be great if you could check whether this makes sense to you. :) |
|
Checked commits mansam/manageiq-providers-openstack@be0c3bb~...c5b6338 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
This is a possible fix for #66 |
|
LGTM +1 |
aufi
reviewed
Sep 19, 2017
| else | ||
| openstack.handled_list(:servers).detect { |s| s.id == clone_task_ref } | ||
| end | ||
| status = instance.state.downcase.to_sym if instance.present? |
There was a problem hiding this comment.
Thanks for the PR. I think we should initialize status local variable always to avoid undefined variable error since it is part of condition on line 12.
There was a problem hiding this comment.
status = instance.state.downcase.to_sym if instance.present? results in status being defined as nil if the condition is false, so an additional initialization shouldn't be necessary.
irb(main):001:0> x = 3 if true
=> 3
irb(main):002:0> x
=> 3
irb(main):003:0> y = 3 if false
=> nil
irb(main):004:0> y
=> nil
irb(main):005:0> z
NameError: undefined local variable or method `z' for main:Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a volume or VM is provisioned in a tenant other than the default, then using
<collection>.get()may fail to find them during the provisioning status check because the request is scoped to the wrong tenant. This PR scopes the request to use the tenant name from the provisioning request if it is a available.This also fixes a performance problem with the cloning check, where in order to work around the scoping problem it was listing every server from every tenant. If the tenant name is available, then it will use
servers.get()instead.(Also some minor co-located lint fixes)