Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provision requirements check to allow exact matches #72

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

tzumainn
Copy link
Contributor

@tzumainn
Copy link
Contributor Author

@gmcculloug Do you think updating the provisioning requirements check like this is okay?

@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2017

Checked commit tzumainn@f3d6003 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug gmcculloug self-assigned this Jul 31, 2017
@gmcculloug
Copy link
Member

@tzumainn Yes, I think you want the minimum flavor to be included in the list, where it is skipped today.

@bdunne made the initial change here, maybe he recalls if there was a reason to use <= in the condition.

@aufi
Copy link
Member

aufi commented Aug 14, 2017

Looks good to me, merging.

Anyway it would be great if @bdunne put his ack on this change too.

@aufi aufi merged commit 48424c9 into ManageIQ:master Aug 14, 2017
@aufi aufi added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 14, 2017
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit b82ee02ee90afa931746acfb7a90251801f82622
Author: Marek Aufart <[email protected]>
Date:   Mon Aug 14 15:57:44 2017 +0200

    Merge pull request #72 from tzumainn/provision-check-update
    
    Update provision requirements check to allow exact matches
    (cherry picked from commit 48424c966ddbd2e58b536d4fa239a40466e8280f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481449

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit cf485f7599abbdbe9626d3cebfcfd94fc8eb47c5
Author: Marek Aufart <[email protected]>
Date:   Mon Aug 14 15:57:44 2017 +0200

    Merge pull request #72 from tzumainn/provision-check-update
    
    Update provision requirements check to allow exact matches
    (cherry picked from commit 48424c966ddbd2e58b536d4fa239a40466e8280f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants