Adjusted DDF schema for create/edit and validation #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you want this in before or after the new |
|
@Fryguy not adjusted to the new column yet, that's why the WIP. Just wanted to store my changes somewhere as I'm working on other stuff now. |
Merged
9 tasks
skateman
changed the title
skateman
force-pushed
the
ddf-adjust
branch
3 times, most recently
from
de1fdd0 to
ceacfd1
Compare
skateman
changed the title
agrare
reviewed
May 12, 2020
|
Checked commit skateman@37ece0c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
skateman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: ManageIQ/manageiq#18818
There's no file upload component yet in the current DDF version. After the v2 update, I can replace the secret text field with a file upload.