Add StorageManager modules to fix CinderManager import paths #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
force-pushed
the
fix-cindermanager-inventory-import-path
branch
from
c1fc461 to
a4f1517
Compare
|
Checked commit mansam@a4f1517 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mansam looks like a core is failing, let me try to fix that |
|
hm, ok, the failure is used by a virtual column ManageIQ/manageiq#17975, we'll need to fix that |
|
Looks good to me, merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the recent inventory refactor PRs moved the location of the CinderManager inventory modules, which causes problems in the console and in other situations because the
require_nested :CinderManagercalls don't work. This adds modules to fix the import path and updates therequire_nestedcall.