Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require hostname if provider is enabled #322

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

alexander-demicev
Copy link

This should prevent requiring hostname during deletion.
https://bugzilla.redhat.com/show_bug.cgi?id=1590204

@aufi aufi added the bug label Jul 24, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commit alexander-demicev@522a5f8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mansam mansam merged commit 42a851e into ManageIQ:master Aug 6, 2018
@simaishi
Copy link
Contributor

simaishi commented Aug 7, 2018

@alexander-demichev Can this be gaprindashvili/yes?

@alexander-demicev
Copy link
Author

@simaishi Hi, yes it can be.

@aufi aufi added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 14, 2018
simaishi pushed a commit that referenced this pull request Sep 13, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 97cbdd36504716fc235cb90247e9a2736d0e1b21
Author: Samuel Lucidi <[email protected]>
Date:   Mon Aug 6 14:41:48 2018 -0400

    Merge pull request #322 from alexander-demichev/require-hostname
    
    Require hostname if provider is enabled
    (cherry picked from commit 42a851eae54e7f0dc6dcaece2d436fb5d9ce6801)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1613420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants