Instances workflow: Allow flavors with disk size of 0 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/gildub/manageiq-providers-openstack/commit/2656bd1109e85a28903a4b490ff5219fa8400870 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label enhancement |
aufi
approved these changes
Jul 11, 2018
|
LGTM |
|
@miq-bot add_label gaprindashvili/yes, fine/yes |
|
@simaishi, Hi, could you please look at gaprindashvili backport. I've added the related BZ in description. Thanks |
|
@gildub Neither BZ is approved for the next Gaprindashvili release, so I'm not able to backport. |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2018
Instances workflow: Allow flavors with disk size of 0 (cherry picked from commit 5598b27) https://bugzilla.redhat.com/show_bug.cgi?id=1643042
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align with OpenStack behaviour when building a new instance and be able to choose a flavor with disk size of 0. The disk size is then determined by the base image build definition.
https://bugzilla.redhat.com/show_bug.cgi?id=1540588
Backport to Gaprindashvili:
https://bugzilla.redhat.com/show_bug.cgi?id=1643042