Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement graph inventory refresh for the network manager #29

Merged

Conversation

mansam
Copy link
Contributor

@mansam mansam commented May 3, 2017

This PR implements the new graph inventory refresh system for the Openstack NetworkManager.

@mansam mansam changed the title Implement graph inventory refresh for the network manager [wip] Implement graph inventory refresh for the network manager May 19, 2017
@miq-bot miq-bot added the wip label May 19, 2017
@miq-bot
Copy link
Member

miq-bot commented May 23, 2017

This pull request is not mergeable. Please rebase and repush.

@mansam mansam force-pushed the network-manager-graph-inventory-refresh branch from b1c7cf7 to ce4f5f7 Compare June 6, 2017 20:33
@mansam
Copy link
Contributor Author

mansam commented Jun 6, 2017

Depends on ManageIQ/manageiq#15325

@mansam mansam force-pushed the network-manager-graph-inventory-refresh branch from ce4f5f7 to 4bed4dc Compare June 6, 2017 20:43
@mansam mansam force-pushed the network-manager-graph-inventory-refresh branch from 4bed4dc to 8abc91b Compare June 7, 2017 18:19
@mansam mansam changed the title [wip] Implement graph inventory refresh for the network manager Implement graph inventory refresh for the network manager Jun 7, 2017
@miq-bot miq-bot removed the wip label Jun 7, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 7, 2017

Checked commits mansam/manageiq-providers-openstack@d7d8e34~...8abc91b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 2 offenses detected

app/models/manageiq/providers/openstack/inventory/collector/network_manager.rb

app/models/manageiq/providers/openstack/inventory/parser/network_manager.rb

@miq-bot
Copy link
Member

miq-bot commented Jun 7, 2017

Some comments on commits mansam/manageiq-providers-openstack@d7d8e34~...8abc91b

spec/vcr_cassettes/manageiq/providers/openstack/infra_manager/refresher_rhos_juno.yml

  • ⚠️ - 144635 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145126 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145307 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145476 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145478 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145484 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145574 - Detected pp. Remove all debugging statements.
  • ⚠️ - 16754 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18531 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18707 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203951 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203989 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203990 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4090 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41339 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41980 - Detected pp. Remove all debugging statements.
  • ⚠️ - 42632 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43310 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43363 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43391 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43396 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43489 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4376 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4378 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46303 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46365 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46519 - Detected pp. Remove all debugging statements.
  • ⚠️ - 71224 - Detected pp. Remove all debugging statements.
  • ⚠️ - 71262 - Detected pp. Remove all debugging statements.
  • ⚠️ - 71263 - Detected pp. Remove all debugging statements.

spec/vcr_cassettes/manageiq/providers/openstack/infra_manager/refresher_rhos_juno_maintenance.yml

  • ⚠️ - 144635 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145126 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145307 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145476 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145478 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145484 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145574 - Detected pp. Remove all debugging statements.
  • ⚠️ - 16754 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18531 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18707 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203951 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203989 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203990 - Detected pp. Remove all debugging statements.
  • ⚠️ - 272764 - Detected pp. Remove all debugging statements.
  • ⚠️ - 273050 - Detected pp. Remove all debugging statements.
  • ⚠️ - 273052 - Detected pp. Remove all debugging statements.
  • ⚠️ - 285428 - Detected pp. Remove all debugging statements.
  • ⚠️ - 287205 - Detected pp. Remove all debugging statements.
  • ⚠️ - 287381 - Detected pp. Remove all debugging statements.
  • ⚠️ - 310013 - Detected pp. Remove all debugging statements.
  • ⚠️ - 310654 - Detected pp. Remove all debugging statements.
  • ⚠️ - 311306 - Detected pp. Remove all debugging statements.
  • ⚠️ - 311984 - Detected pp. Remove all debugging statements.
  • ⚠️ - 312037 - Detected pp. Remove all debugging statements.
  • ⚠️ - 312065 - Detected pp. Remove all debugging statements.
  • ⚠️ - 312070 - Detected pp. Remove all debugging statements.
  • ⚠️ - 312163 - Detected pp. Remove all debugging statements.
  • ⚠️ - 314977 - Detected pp. Remove all debugging statements.
  • ⚠️ - 315039 - Detected pp. Remove all debugging statements.
  • ⚠️ - 315193 - Detected pp. Remove all debugging statements.
  • ⚠️ - 339898 - Detected pp. Remove all debugging statements.
  • ⚠️ - 339936 - Detected pp. Remove all debugging statements.
  • ⚠️ - 339937 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4090 - Detected pp. Remove all debugging statements.
  • ⚠️ - 413309 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41339 - Detected pp. Remove all debugging statements.
  • ⚠️ - 413800 - Detected pp. Remove all debugging statements.
  • ⚠️ - 413981 - Detected pp. Remove all debugging statements.
  • ⚠️ - 414150 - Detected pp. Remove all debugging statements.
  • ⚠️ - 414152 - Detected pp. Remove all debugging statements.
  • ⚠️ - 414158 - Detected pp. Remove all debugging statements.
  • ⚠️ - 414248 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41980 - Detected pp. Remove all debugging statements.
  • ⚠️ - 42632 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43310 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43363 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43391 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43396 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43489 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4376 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4378 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46303 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46365 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46519 - Detected pp. Remove all debugging statements.
  • ⚠️ - 471558 - Detected pp. Remove all debugging statements.
  • ⚠️ - 471844 - Detected pp. Remove all debugging statements.
  • ⚠️ - 471846 - Detected pp. Remove all debugging statements.
  • ⚠️ - 484222 - Detected pp. Remove all debugging statements.
  • ⚠️ - 485999 - Detected pp. Remove all debugging statements.
  • ⚠️ - 486175 - Detected pp. Remove all debugging statements.
  • ⚠️ - 508807 - Detected pp. Remove all debugging statements.
  • ⚠️ - 509448 - Detected pp. Remove all debugging statements.
  • ⚠️ - 510100 - Detected pp. Remove all debugging statements.
  • ⚠️ - 510778 - Detected pp. Remove all debugging statements.
  • ⚠️ - 510831 - Detected pp. Remove all debugging statements.
  • ⚠️ - 510859 - Detected pp. Remove all debugging statements.
  • ⚠️ - 510864 - Detected pp. Remove all debugging statements.
  • ⚠️ - 510957 - Detected pp. Remove all debugging statements.
  • ⚠️ - 513771 - Detected pp. Remove all debugging statements.
  • ⚠️ - 513833 - Detected pp. Remove all debugging statements.
  • ⚠️ - 513987 - Detected pp. Remove all debugging statements.
  • ⚠️ - 538692 - Detected pp. Remove all debugging statements.
  • ⚠️ - 538730 - Detected pp. Remove all debugging statements.
  • ⚠️ - 538731 - Detected pp. Remove all debugging statements.
  • ⚠️ - 612103 - Detected pp. Remove all debugging statements.
  • ⚠️ - 612594 - Detected pp. Remove all debugging statements.
  • ⚠️ - 612775 - Detected pp. Remove all debugging statements.
  • ⚠️ - 612944 - Detected pp. Remove all debugging statements.
  • ⚠️ - 612946 - Detected pp. Remove all debugging statements.
  • ⚠️ - 612952 - Detected pp. Remove all debugging statements.
  • ⚠️ - 613042 - Detected pp. Remove all debugging statements.
  • ⚠️ - 71224 - Detected pp. Remove all debugging statements.
  • ⚠️ - 71262 - Detected pp. Remove all debugging statements.
  • ⚠️ - 71263 - Detected pp. Remove all debugging statements.

@tzumainn
Copy link
Contributor

tzumainn commented Jun 8, 2017

Tested, and it looks good! Thanks/

@tzumainn tzumainn merged commit 22ed63a into ManageIQ:master Jun 8, 2017
@tzumainn tzumainn added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants