Combine InfraManager and child manager refresh queues #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CloudManager's refresh queues were consolidated, the individual NetworkManager refresh worker was removed. However, the InfraManager's queues were not combined at the same time, resulting in Infra network refresh events not being picked up. This commit ensures that the Infra Manager's refresh worker picks up queued refreshes for its child managers as well. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1572760
|
Checked commit mansam@5864c40 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good to me, merging! |
simaishi
pushed a commit
that referenced
this pull request
May 16, 2018
Combine InfraManager and child manager refresh queues (cherry picked from commit 13b43f2) https://bugzilla.redhat.com/show_bug.cgi?id=1572760
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CloudManager's refresh queues were consolidated,
the individual NetworkManager refresh worker was removed.
However, the InfraManager's queues were not combined at
the same time, resulting in Infra network refresh events
not being picked up. This commit ensures that the Infra
Manager's refresh worker picks up queued refreshes for
its child managers as well.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1571836