Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CinderManager inventory classes #282

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Move CinderManager inventory classes #282

merged 1 commit into from
Apr 27, 2018

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Apr 27, 2018

Moves the CinderManager inventory classes out from being nested under StorageManager so that ManagerRefresh::Inventory.persister_class_for and ManagerRefresh::Inventory.parser_class_for can find them.

@mansam
Copy link
Contributor Author

mansam commented Apr 27, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1570965

@mansam mansam requested a review from agrare April 27, 2018 18:32
@mansam
Copy link
Contributor Author

mansam commented Apr 27, 2018

@agrare

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2018

Checked commit mansam@08ae743 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare merged commit c691435 into ManageIQ:master Apr 27, 2018
@agrare agrare added this to the Sprint 85 Ending May 7, 2018 milestone Apr 27, 2018
simaishi pushed a commit that referenced this pull request Apr 30, 2018
@agrare @simaishi
Merge pull request #282 from mansam/move-cinder-manager-inventory-cla…
bb56c82 
…sses

Move CinderManager inventory classes
(cherry picked from commit c691435)

https://bugzilla.redhat.com/show_bug.cgi?id=1573215
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit bb56c82c0436b92278931f1fbd89b220e9f9a07f
Author: Adam Grare <[email protected]>
Date:   Fri Apr 27 15:19:05 2018 -0400

    Merge pull request #282 from mansam/move-cinder-manager-inventory-classes
    
    Move CinderManager inventory classes
    (cherry picked from commit c69143543d3379196ff8f1d1ea3416a837ff610a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1573215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees
No one assigned
Labels
blocker gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mansam @miq-bot @simaishi @agrare