Add Openstack CinderManager EventCatcher

[mansam]

No description provided.

[mansam]

@aufi please review when you can, this is part of the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1570965

[JPrause]

@miq-bot add_label blocker

[JPrause]

@mansam if this can be backported, please add label gaprindashvili/yes

[miq-bot]

Checked commits mansam/manageiq-providers-openstack@beb5f3d~...c4eb07f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 12 offenses detected

app/models/manageiq/providers/openstack/inventory/persister/target_collection.rb

• ❗ - Line 49, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

app/models/manageiq/providers/openstack/storage_manager/cinder_manager.rb

• ❗ - Line 69, Col 70 - Layout/SpaceBeforeBlockBraces - Space missing to the left of {.
• ❗ - Line 69, Col 9 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 70, Col 69 - Layout/SpaceBeforeBlockBraces - Space missing to the left of {.

app/models/manageiq/providers/openstack/storage_manager/cinder_manager/event_parser.rb

• ❗ - Line 21, Col 78 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 22, Col 78 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 23, Col 78 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 24, Col 78 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 30, Col 13 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.
• ❗ - Line 8, Col 58 - Style/GlobalVars - Do not introduce global variables.
• ❗ - Line 8, Col 58 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 8, Col 66 - Style/GlobalVars - Do not introduce global variables.

[JPrause]

@Ladas since this is a blocker PR, can you review asap. We have a build coming up and are trying to get these blocker PRs merged.

[Ladas]

Looks good 👍

@mansam was there no event catcher before? Btw. in other providers we just have 1 events catcher for cloud,network and storage, to spare some workers. Maybe we could refactor it to this later?

[mansam]

@Ladas There wasn't as far as I could tell from the list of workers. I'd very much like to refactor down to a single event catcher when we've got a little more time to breathe. :)

[simaishi]

@mansam Yet another conflict on VCRs... I assume you'd need to create a separate PR for Gaprindashvili?

[mansam]

@simaishi Yes, if you're running into a VCR conflict I'll have to make a new PR.

[simaishi]

Backported to Gaprindashvili via #283