Catch error when volume creation fails #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
error-on-volume-check
branch
from
bdad5cf to
f326119
Compare
mansam
suggested changes
Apr 11, 2018
| volume = service.volumes.get(volume_attrs[:uuid]) | ||
| status = volume.try(:status) | ||
| if status == "error" | ||
| raise MiqException::MiqProvisionError, "An error occurred while provisioning Instance #{volume.name}" |
There was a problem hiding this comment.
This error message is sort of confusing because it says Instance but then names a volume. It should probably be reworded to make it clear that a volume failed to be provisioned.
alexander-demicev
force-pushed
the
error-on-volume-check
branch
from
f326119 to
642e65f
Compare
|
Checked commit alexander-demicev@642e65f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mansam
approved these changes
Apr 18, 2018
|
@alexander-demichev Can this be |
|
@miq-bot add_label gaprindashvili/yes |
|
@simaishi Hi, sure. |
simaishi
pushed a commit
that referenced
this pull request
May 15, 2018
Catch error when volume creation fails (cherry picked from commit 2fae362) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578125
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handling for status "error"
https://bugzilla.redhat.com/show_bug.cgi?id=1562355