Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gnocchi default granularity configurable in Settings #267

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

aufi
Copy link
Member

@aufi aufi commented Apr 9, 2018

ManageIQ counts with default "minimal" granularity for collecting Metrics via
OpenStack Gnocchi service. This PR makes the default granularity an option in
Settings which allows configure it on customer side.

Adjusting this should resolve Metric NotFound errors caused by not matching
granularity.

Solves https://bugzilla.redhat.com/show_bug.cgi?id=1529449

ManageIQ counts with default "minimal" granularity for collecting Metrics via
OpenStack Gnocchi service. This PR makes the default granularity an option in
Settings which allows configure it on customer side.

Adjusting this should resolve Metric NotFound errors caused by not matching
granularity.

Solves https://bugzilla.redhat.com/show_bug.cgi?id=1529449
@aufi aufi force-pushed the gnocchi_granularity_settings branch from 6cb4976 to f800572 Compare April 9, 2018 08:13
@miq-bot
Copy link
Member

miq-bot commented Apr 9, 2018

Checked commit aufi@f800572 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@mansam mansam merged commit bf0f3d2 into ManageIQ:master Apr 11, 2018
@aufi aufi added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 24, 2018
simaishi pushed a commit that referenced this pull request May 15, 2018
Make Gnocchi default granularity configurable in Settings
(cherry picked from commit bf0f3d2)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578388
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2357d40b4dddb15438c46b66f0fb36c621ba0b18
Author: Samuel Lucidi <[email protected]>
Date:   Wed Apr 11 13:11:55 2018 -0400

    Merge pull request #267 from aufi/gnocchi_granularity_settings
    
    Make Gnocchi default granularity configurable in Settings
    (cherry picked from commit bf0f3d2e448d0365d263a1cfb4ba740763da86f1)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578388

@chrispy1
Copy link

@miq-bot add_label fine/yes

@simaishi
Copy link
Contributor

The backport to Fine branch was split.

config/settings.yml (manageiq repo)

commit c51a6f4da2862c962709e904a41545546942848e
Author: Samuel Lucidi <[email protected]>
Date:   Wed Apr 11 13:11:55 2018 -0400

    Merge pull request #267 from aufi/gnocchi_granularity_settings
    
    Make Gnocchi default granularity configurable in Settings
    (cherry picked from commit bf0f3d2e448d0365d263a1cfb4ba740763da86f1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1578575

lib/manageiq/providers/openstack/legacy/openstack_handle/metric_delegate.rb (manageiq-gems-pending repo)

commit d44d6634244caaba93f4784264192257f0c477df
Author: Samuel Lucidi <[email protected]>
Date:   Wed Apr 11 13:11:55 2018 -0400

    Merge pull request #267 from aufi/gnocchi_granularity_settings
    
    Make Gnocchi default granularity configurable in Settings
    (cherry picked from commit bf0f3d2e448d0365d263a1cfb4ba740763da86f1)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants