Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gaprindashvili] Improve network manager refresh speed #251

Merged
merged 5 commits into from
Mar 16, 2018
Merged

[Gaprindashvili] Improve network manager refresh speed #251

merged 5 commits into from
Mar 16, 2018

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Mar 13, 2018 •
edited by simaishi
Loading

@mansam
Copy link
Contributor Author

mansam commented Mar 13, 2018

@miq-bot add_label gaprindashvili/yes

@simaishi simaishi self-assigned this Mar 13, 2018
@simaishi simaishi requested a review from aufi March 13, 2018 12:32
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2018

This pull request is not mergeable. Please rebase and repush.

@mansam mansam force-pushed the gaprindashvili-improve-network-manager-refresh-speed branch from 6a5aecc to 4581c4e Compare March 13, 2018 15:22
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2018

Checked commits mansam/manageiq-providers-openstack@f6d2031~...4581c4e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
35 files checked, 2 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

app/models/manageiq/providers/openstack/network_manager/refresh_parser.rb

@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2018

Some comments on commits mansam/manageiq-providers-openstack@f6d2031~...4581c4e

spec/models/manageiq/providers/openstack/network_manager/cloud_subnet_refresh_spec.rb

  • ⚠️ - 131 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 145 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@simaishi
Copy link
Contributor

@aufi Is this good to go?

@simaishi simaishi merged commit 4848287 into ManageIQ:gaprindashvili Mar 16, 2018
@simaishi simaishi added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 16, 2018
@simaishi simaishi mentioned this pull request Mar 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aufi aufi aufi approved these changes

Assignees

@simaishi simaishi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mansam @miq-bot @simaishi @aufi